Add option to generate XML test cases (--write-xml-tests) #1181
Conversation
…ered to Test-Comp Add option to provide original source file and its hash sum; TODO REMOVE namespace change
|
Wouldn't this be better as a ktest tool option, similar to the binary output one? |
|
@kren1 Not for test-comp. |
| @@ -289,6 +289,22 @@ namespace { | |||
| cl::desc("Link the llvm libc++ library into the bitcode (default=false)"), | |||
| cl::init(false), | |||
| cl::cat(LinkCat)); | |||
|
|
|||
| cl::OptionCategory TestCompCat("Options specific to Test-Comp", | |||
| "Options specific to test-comp."); | |||
There was a problem hiding this comment.
Can you say something like "These are options specific to the Test-Comp competition" for consistency with the other category descriptions which are full sentences?
| "Options specific to test-comp."); | ||
|
|
||
| llvm::cl::opt<bool> WriteXMLTests("write-xml-tests", | ||
| llvm::cl::desc("Write XML-formated tests"), |
| for (unsigned i=0; i<b.numObjects; i++) | ||
| delete[] b.objects[i].bytes; | ||
| delete[] b.objects; | ||
| if (!WriteXMLTests) |
There was a problem hiding this comment.
I don't think this should be an OR, we should allow the generation of both .ktest and .xml files
| cl::cat(TestCompCat)); | ||
|
|
||
| llvm::cl::opt<std::string> TCOrig("tc-orig", | ||
| llvm::cl::desc("Test-Comp original file"), |
There was a problem hiding this comment.
Can you explain a bit what this is?
|
What about some sort of usage like this A nice thing about this approach is it doesn't pollute KLEE code, but more importantly it's more flexible. For example you could do something like |
|
I think we should add this, as it's not an exotic option -- this XML-formatted tests are now supported by many other tools. There are also a number of KLEE-based tools participating in Test-Comp, and it's good to eliminate code duplication, especially if the format changes in the future. So let's merge this. @MartinNowack can you make the small changes I requested? |
|
@MartinNowack You will also need to fix compilation for LLVM < 4: |
|
@MartinNowack any reason not to merge this? We receive regular inquiries about this, most recently on klee-dev. |
|
@MartinNowack I know this is not a priority, and from what I understand you don't plan to revive it. So let's close it. |
Add option to generate xml testcases. This patch generates test cases as XML files.
In addition, test-comp-specific, additional arguments are specific to generate experiment descriptions.