[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version is missing @babel/runtime #2169

Closed
MelonCola opened this issue Apr 11, 2021 · 2 comments
Closed

Latest version is missing @babel/runtime #2169

MelonCola opened this issue Apr 11, 2021 · 2 comments
Labels
bug

Comments

@MelonCola
Copy link
MelonCola commented Apr 11, 2021 •
edited
Loading

The newest version causes a Error: Cannot find module '@babel/runtime/helpers/interopRequireDefault' error, which can be fixed by adding an @babel/runtime to the dependencies.

I'm not going to try making a PR as I'm not familiar with babel and am not positive this is the correct solution, but as far as I can tell, from the docs here https://babeljs.io/docs/en/babel-plugin-transform-runtime, it is.
@MelonCola MelonCola changed the title Latest commit is missing @babel/runtime Latest version is missing @babel/runtime Apr 11, 2021
@letmaik letmaik mentioned this issue Apr 12, 2021
Merged
@josdejong
Copy link
Owner
josdejong commented Apr 12, 2021 •
edited
Loading

Thanks for reporting @MelonCola . This regression was introduced in v9.3.1, where I added @babel/runtime in order to enable using iterators in #2155. I've now reverted this, and we will look deeper into this in #2155 to set up a correct solution with babel, that should not introduce @babel/runtime as a dependency.

@josdejong josdejong mentioned this issue Apr 12, 2021
Merged
8 tasks
@josdejong
Copy link
Owner

Fix is published now in v9.3.2

@josdejong josdejong added the bug label Apr 12, 2021
joshhansen pushed a commit to LearnSomethingTeam/mathjs that referenced this issue Sep 16, 2021
@josdejong @joshhansen
Fix josdejong#2169: mathjs requesting @babel/runtime dependency. Pu…
9a410d7 
…blish v9.3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josdejong @MelonCola