[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & automatically build Docker image #340

Closed
wants to merge 2 commits into from
Closed

Refactor & automatically build Docker image #340

wants to merge 2 commits into from

Conversation

minus7
Copy link
@minus7 minus7 commented May 27, 2023 •
edited
Loading
  • Refactor Dockerfile
    • Use code from context instead of cloning the repo
    • Download dependencies first for caching
    • Run as unprivileged account (note that this break running on ports
      <1024 on Docker <20.03; default ports changed accordingly)
  • I'm not actually sure the ca-certificates package is required in the image, requesting certificates seems to work without it, though I did not test fully obtaining one.
  • Automatically build and deploy Docker image via GitHub Actions
    • I mainly did this so I can use it right away. Dunno if it makes sense, especially since images are on Docker Hub already.

@minus7
Refactor Dockerfile
5da7960 
- Use code from context instead of cloning the repo
- Download dependencies first for caching
- Run as unprivileged account (note that this break running on ports
  <1024 on Docker <20.03; default ports changed accordingly)
@minus7
Automatically build and deploy Docker image
0e9f8ba
@gbonnefille
Copy link

As stated in #293 it is possible to reduce the footprint and increase security, going from scratch.

@simu simu mentioned this pull request Jul 10, 2023
Open
@minus7 minus7 closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minus7 @gbonnefille