Fix invalid nxdomain response (fixes #257) #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, the proper source for the SOA record requirement is this: https://datatracker.ietf.org/doc/html/rfc2308#section-3 ("Name servers authoritative for a zone MUST include the SOA record of the zone in the authority section of the response when reporting an NXDOMAIN or indicating that no data of the requested type exists.") |
a7e3094
to
b1ed162
Compare
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: İlteriş Yağıztegin Eroğlu <me@linuxgemini.space> Signed-off-by: İlteriş Yağıztegin Eroğlu <me@linuxgemini.space>
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: Yannik Sembritzki <yannik@sembritzki.me> Signed-off-by: İlteriş Yağıztegin Eroğlu <me@linuxgemini.space>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #257