[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): support branch/tag delete events (JENKINS-66638). #36

Merged
merged 9 commits into from
Nov 2, 2021
Merged

feat(webhook): support branch/tag delete events (JENKINS-66638). #36

merged 9 commits into from
Nov 2, 2021

Conversation

mortenkri
Copy link
Contributor
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira

Fixes https://issues.jenkins.io/browse/JENKINS-66638

@mortenkri mortenkri changed the title feat(webhook): webhooks pushes branch/tag delete events (JENKINS-66638). feat: have webhooks push branch/tag delete events (JENKINS-66638). Nov 1, 2021
@mortenkri
Copy link
Contributor Author

I need to push more code :D Sorry about that. Will update the PR.

@lafriks lafriks added this to the 1.4.0 milestone Nov 2, 2021
@mortenkri
Copy link
Contributor Author

This PR now contains both enhancements and fixes:

  • Implements the enhancement (JENKINS-66638). Webhook is now pushing Delete branch/tag events and handles them correctly when received in Jenkins.
  • Also fixes the bug: When adding a new OrganizationFolder with GiteaNavigator, adding the WebhookRegistrationTrait failed with NPE when saving due to missing jelly stuff. Fixed and tested.
  • Also fixes the bug: When using TagDiscoveryTrait, webhook will push Create events correctly and it is processed by the plugin. However, the new tag is not visible in Jenkins and a re-scan is needed. Fixed and tested.

The question is if it is OK to merge all these enhancement and fixes as part of JENKINS-66638 or if we should create two new Jira tickets in order to describe the bugs and refer to the issues here?

I am also not certain if the isMatch method in GiteaDeleteSCMEvent is needed or if it could just return false (from parent)?

@lafriks
Copy link
Contributor
lafriks commented Nov 2, 2021

It would be better to move bug fixes into separate PRs (no need to create Jira tickets)

@mortenkri
Copy link
Contributor Author
mortenkri commented Nov 2, 2021

@lafriks I have moved the bugfixes to two new PRs. This now (again) only covers JENKINS-66638. And again I am not sure what to do with the isMatch method ref my comments. I am tempted to remove it and let the parent return false for the scenario.

@mortenkri
Copy link
Contributor Author

@lafriks Fixed the same refType stuff here is in #38. In addition I removed the isMatch method and things works still.

@mortenkri mortenkri changed the title feat: have webhooks push branch/tag delete events (JENKINS-66638). feat(webhook): support branch/tag delete events (JENKINS-66638). Nov 2, 2021
@mortenkri
Copy link
Contributor Author

@lafriks Any clue on when 1.4.0 will be released?

Copy link
Contributor
@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@lafriks lafriks merged commit 01588cc into jenkinsci:master Nov 2, 2021
@mortenkri mortenkri deleted the JENKINS-66638 branch November 2, 2021 20:02
@lafriks
Copy link
Contributor
lafriks commented Nov 2, 2021

@lafriks Any clue on when 1.4.0 will be released?

Probably when we manage to get CD workflow automatized we can release it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants