-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhook): support branch/tag delete events (JENKINS-66638). #36
Conversation
I need to push more code :D Sorry about that. Will update the PR. |
This PR now contains both enhancements and fixes:
The question is if it is OK to merge all these enhancement and fixes as part of JENKINS-66638 or if we should create two new Jira tickets in order to describe the bugs and refer to the issues here? I am also not certain if the isMatch method in GiteaDeleteSCMEvent is needed or if it could just return false (from parent)? |
src/main/java/org/jenkinsci/plugin/gitea/GiteaDeleteSCMEvent.java
Outdated
Show resolved
Hide resolved
It would be better to move bug fixes into separate PRs (no need to create Jira tickets) |
@lafriks I have moved the bugfixes to two new PRs. This now (again) only covers JENKINS-66638. And again I am not sure what to do with the isMatch method ref my comments. I am tempted to remove it and let the parent return false for the scenario. |
src/main/java/org/jenkinsci/plugin/gitea/GiteaDeleteSCMEvent.java
Outdated
Show resolved
Hide resolved
@lafriks Any clue on when 1.4.0 will be released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
src/main/java/org/jenkinsci/plugin/gitea/client/api/GiteaDeleteEvent.java
Outdated
Show resolved
Hide resolved
Probably when we manage to get CD workflow automatized we can release it |
Fixes https://issues.jenkins.io/browse/JENKINS-66638