Always show FFmpeg path in Transcoding page #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO this should wait for jellyfin/jellyfin#844 |
Removed the 'hide' and 'required' settings from the html to always show the FFmpeg path to user and also allow user to remove a custom path and return to using whatever is available from system $PATH.
|
@JustAMan This PR should be merge too, now that jellyfin/jellyfin#844 has gone. |
JustAMan
reviewed
Mar 7, 2019
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
JustAMan
approved these changes
Mar 7, 2019
|
Absolutely not. |
cvium
reviewed
Mar 8, 2019
cvium
reviewed
Mar 8, 2019
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
cvium
reviewed
Mar 8, 2019
Co-Authored-By: ploughpuff <33969763+ploughpuff@users.noreply.github.com>
joshuaboniface
approved these changes
Mar 10, 2019
|
Damn caching, thought I purged it. Yup works wonderfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the 'hide' and 'required' settings from the html to always show the FFmpeg path.
Allow user to submit empty FFmpeg path from Transcoding path to facilitate removal of Custom path without requiring a system restart.
Associated changes on Jellyfin:
jellyfin/jellyfin#844