[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the movie name instead of folder name #924

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Use the movie name instead of folder name #924

merged 1 commit into from
Feb 18, 2019

Conversation

cvium
Copy link
Member
@cvium cvium commented Feb 17, 2019

Changes
Removed the dependency on folder name. Because of the grouping, it should be fine to use the movie name.
Issues
Fixes #921

@JustAMan JustAMan merged commit f274d02 into jellyfin:release-10.2.z Feb 18, 2019
@JustAMan JustAMan mentioned this pull request Feb 18, 2019
Closed
@EraYaN
Copy link
Member
EraYaN commented Feb 18, 2019

It would be great if the folder name could still be an option. (Like in other metadata managers)

Cause now we just switched to the other behavior, messing people up that did it the opposite way.

@liggy1
Copy link
liggy1 commented Feb 18, 2019

I agree with EraYaN. Have been organizing by folder name since I started using Emby. Having a library of a certain size, keeping everything in one folder makes it almost impossible to keep an overview.
Since 10.2.0 this way of organizing the library no longer works, when there are two (or probably more) versions of the same movie in one directory, as shown here. Building a version with this PR, it no longer only shows the entry twice, but can only identify one, while the other one appears as file name:
image

Would it be an option to only revert to filename recognition in the top level directory, but keep directory recognition for everything that is inside a sub-directory?

@cvium cvium deleted the fix_movie_matching branch February 18, 2019 17:17
cvium added a commit to cvium/jellyfin that referenced this pull request Feb 19, 2019
@cvium
Revert "Merge pull request jellyfin#924 from cvium/fix_movie_matching"
5181427 
This reverts commit f274d02, reversing
changes made to 4b4399f.
@cvium cvium mentioned this pull request Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cvium @EraYaN @liggy1 @JustAMan @joshuaboniface @Bond-009