[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian packaging improvements #9

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Debian packaging improvements #9

merged 3 commits into from
Dec 9, 2018

Conversation

joshuaboniface
Copy link
Member

Multiple improvements to the Debian packaging, including:

  1. Renaming everything to jellyfin.
  2. Fix up the initscript/unit file/upstart job to use proper dotnet startup.
  3. Replace hardcoded /var/lib/emby path in MediaBrowser.Server.Mono/app.config.

@joshuaboniface
Copy link
Member Author

This builds a Debian binary package with a working service for me.

$ systemctl status jellyfin
● jellyfin.service - Jellyfin Media Server
   Loaded: loaded (/lib/systemd/system/jellyfin.service; enabled; vendor preset: enabled)
   Active: active (running) since Sun 2018-12-09 17:38:25 EST; 8min ago
 Main PID: 5588 (dotnet)
   CGroup: /system.slice/jellyfin.service
           └─5588 /usr/bin/dotnet /usr/lib/jellyfin/bin/EmbyServer.dll

@joshuaboniface joshuaboniface merged commit ed02c0b into master Dec 9, 2018
JustAMan
JustAMan reviewed Dec 9, 2018
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also might make sense to include a migration script for moving from Emby to Jellyfin

debian/bin/jellyfin
fi
fi

# Data directory where Emby database, cache and logs are stored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs fixing :-)

debian/jellyfin.init
case "$1" in
start)
if [ "$pid" == "" ]; then
echo "Starting Emby..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And those echo lines also need a naming fix

@joshuaboniface joshuaboniface mentioned this pull request Dec 9, 2018
Merged
@joshuaboniface
Copy link
Member Author

Yea, there is a ton wrong with this branch, I was too hasty in self-merging - I've reverted it to do some more testing.

nvllsvm pushed a commit that referenced this pull request Dec 27, 2018
@joshuaboniface
Merge pull request #9 from jellyfin/debian-packaging
98d9da1 
Debian packaging improvements
Bond-009 pushed a commit that referenced this pull request Mar 7, 2019
@LogicalPhallacy
Merge pull request #9 from jellyfin/master
8bf88f4 
Yanking in latest changes
JustAMan pushed a commit that referenced this pull request Feb 25, 2020
@Artiume
Merge pull request #9 from jellyfin/master
d4470b5 
nightly
@0xseed 0xseed mentioned this pull request Mar 4, 2020
Closed
@timonoj timonoj mentioned this pull request Aug 30, 2020
Closed
@CutterXYZ CutterXYZ mentioned this pull request Feb 20, 2021
Closed
@Markusvanhode Markusvanhode mentioned this pull request Jan 7, 2023
Closed
@peioe peioe mentioned this pull request Apr 27, 2023
Closed
@halexh halexh mentioned this pull request Feb 25, 2024
Closed
@Certefied Certefied mentioned this pull request Mar 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuaboniface @JustAMan