More warning fixes #885
More warning fixes #885
Conversation
| @@ -101,7 +118,7 @@ private static async Task StartApp(StartupOptions options) | |||
| SQLitePCL.Batteries_V2.Init(); | |||
|
|
|||
| // Allow all https requests | |||
| ServicePointManager.ServerCertificateValidationCallback = new RemoteCertificateValidationCallback(delegate { return true; }); | |||
| ServicePointManager.ServerCertificateValidationCallback = new RemoteCertificateValidationCallback(delegate { return true; } ); | |||
There was a problem hiding this comment.
On an unrelated note, this should be configurable. I believe this is for out going connections, and it's not very good practice to have it as default.
There was a problem hiding this comment.
But probably also out of scope. It might warrant a //TODO
There was a problem hiding this comment.
Yeah, this is a bad practice, should be off by default.
Definitely warrants a TODO at least.
| } | ||
|
|
||
| long virt = real - offset; | ||
| if (virt < 0 || virt > Length) | ||
| { | ||
| throw new ArgumentException(); | ||
| throw new ArgumentException("Invalid position", nameof(origin)); |
There was a problem hiding this comment.
I think bad position should be tied to d, not origin here:
| throw new ArgumentException("Invalid position", nameof(origin)); | |
| throw new ArgumentException("Invalid position", nameof(d)); |
| public long Start; | ||
| public long Length; | ||
| public string ContentType { get; set; } | ||
|
|
There was a problem hiding this comment.
do we need empty lines between those? you didn't use them in other files here
| } | ||
| } | ||
|
|
||
| long start = 0; |
There was a problem hiding this comment.
| long start = 0; | |
| long start = data.Position; |
| @@ -107,6 +110,7 @@ internal static string CheckBadChars(string name) | |||
| switch (crlf) | |||
| { | |||
| case 0: | |||
| { | |||
There was a problem hiding this comment.
why add braces here? they seem to be excessive for me
There was a problem hiding this comment.
Pretty sure the the analyzer wanted it.
Co-Authored-By: Bond-009 <bond.009@outlook.com>
No description provided.