Fix potential NullReferenceException #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Changes seem to be in line with others around.
I wonder if audioStream should ever be null here, maybe its being null is a bug...
Oh, and @WillWill56, I don't remember you adding yourself to CONTRIBUTORS.md yet... please do! 😉
|
Oh whoops, how should I do that? Yeah, seems like working on a buggy plugin is the main reason I found this bug, will probably have to fix something related to this in the tunein plugin very soon. |
https://jellyfin.readthedocs.io/en/latest/contributor-docs/contributing-code/#contributorsmd |
|
Guess I missed that. Include the change in this pull request? |
|
Either in this one or in another about HttpClient, whatever suits you more. |
cvium
approved these changes
Feb 12, 2019
JustAMan
approved these changes
Feb 12, 2019
joshuaboniface
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added in a missing null-conditional operator (?) to prevent a NullReferenceException from being thrown.
Issues
Fixes #871