[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to reduce allocations #848

Merged
merged 12 commits into from
Feb 20, 2019
Merged

Minor changes to reduce allocations #848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64d5ec1
Use HashSets for increased perf
Bond-009 Feb 8, 2019
41fb1e5
Tuple -> ValueTuple
Bond-009 Feb 8, 2019
3e6819c
Don't clone lists
Bond-009 Feb 8, 2019
7722cb3
Some Lists -> IEnumerable
Bond-009 Feb 9, 2019
9dba930
Warn faster for slow requests
Bond-009 Feb 9, 2019
da9418c
Useless copy
Bond-009 Feb 9, 2019
8d98885
Less string allocations
Bond-009 Feb 9, 2019
585b520
Last bits
Bond-009 Feb 9, 2019
ea446fd
Revert back to netcoreapp2.1
Bond-009 Feb 9, 2019
3f13851
Address comments
Bond-009 Feb 12, 2019
5835c4b
Remove comment
Bond-009 Feb 13, 2019
4811e76
Merge branch 'master' into perf
Bond-009 Feb 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't clone lists
  • Loading branch information
@Bond-009
Bond-009 committed Feb 12, 2019
commit 3e6819c718a45b44eb3f84439d118ad849ccffa8
4 changes: 2 additions & 2 deletions Emby.Server.Implementations/Data/SqliteItemRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ public void SaveItem(BaseItem item, CancellationToken cancellationToken)
throw new ArgumentNullException(nameof(item));
}

SaveItems(new List<BaseItem> { item }, cancellationToken);
SaveItems(new [] { item }, cancellationToken);
}

public void SaveImages(BaseItem item)
Expand Down Expand Up @@ -576,7 +576,7 @@ public void SaveImages(BaseItem item)
/// or
/// cancellationToken
/// </exception>
public void SaveItems(List<BaseItem> items, CancellationToken cancellationToken)
public void SaveItems(IEnumerable<BaseItem> items, CancellationToken cancellationToken)
{
if (items == null)
{
Expand Down
12 changes: 5 additions & 7 deletions Emby.Server.Implementations/Library/LibraryManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,18 +1806,16 @@ public void CreateItem(BaseItem item, BaseItem parent)
/// <returns>Task.</returns>
public void CreateItems(IEnumerable<BaseItem> items, BaseItem parent, CancellationToken cancellationToken)
{
var list = items.ToList();
JustAMan marked this conversation as resolved.
Show resolved Hide resolved

ItemRepository.SaveItems(list, cancellationToken);
ItemRepository.SaveItems(items, cancellationToken);

foreach (var item in list)
foreach (var item in items)
{
RegisterItem(item);
}

if (ItemAdded != null)
{
foreach (var item in list)
foreach (var item in items)
{
// With the live tv guide this just creates too much noise
if (item.SourceType != SourceType.Library)
Expand Down Expand Up @@ -1851,7 +1849,7 @@ public void UpdateImages(BaseItem item)
/// <summary>
/// Updates the item.
/// </summary>
public void UpdateItems(List<BaseItem> items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken)
public void UpdateItems(IEnumerable<BaseItem> items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken)
{
foreach (var item in items)
{
Expand Down Expand Up @@ -1906,7 +1904,7 @@ public void UpdateItems(List<BaseItem> items, BaseItem parent, ItemUpdateType up
/// <returns>Task.</returns>
public void UpdateItem(BaseItem item, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken)
{
UpdateItems(new List<BaseItem> { item }, parent, updateReason, cancellationToken);
UpdateItems(new [] { item }, parent, updateReason, cancellationToken);
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion MediaBrowser.Controller/Library/ILibraryManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void AddParts(IEnumerable<IResolverIgnoreRule> rules,
/// <summary>
/// Updates the item.
/// </summary>
void UpdateItems(List<BaseItem> items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken);
void UpdateItems(IEnumerable<BaseItem> items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken);
void UpdateItem(BaseItem item, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken);

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion MediaBrowser.Controller/Persistence/IItemRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public interface IItemRepository : IRepository
/// </summary>
/// <param name="items">The items.</param>
/// <param name="cancellationToken">The cancellation token.</param>
void SaveItems(List<BaseItem> items, CancellationToken cancellationToken);
void SaveItems(IEnumerable<BaseItem> items, CancellationToken cancellationToken);

void SaveImages(BaseItem item);

Expand Down