[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed some unused fields #829

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Removed some unused fields #829

merged 2 commits into from
Feb 18, 2019

Conversation

Bond-009
Copy link
Member
@Bond-009 Bond-009 commented Feb 6, 2019

Less references to pass around 🎉

JustAMan
JustAMan reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I am not getting the reason behind some of the changes, could you please explain?

Emby.Server.Implementations/ApplicationHost.cs Show resolved Hide resolved
Emby.Server.Implementations/Collections/CollectionImageProvider.cs Show resolved Hide resolved
Emby.Server.Implementations/Data/CleanDatabaseScheduledTask.cs Show resolved Hide resolved
Emby.Server.Implementations/FFMpeg/FFMpegLoader.cs Show resolved Hide resolved
Emby.Server.Implementations/Library/CoreResolutionIgnoreRule.cs Show resolved Hide resolved
Emby.Server.Implementations/Library/UserManager.cs Show resolved Hide resolved
Emby.Server.Implementations/LiveTv/TunerHosts/BaseTunerHost.cs Show resolved Hide resolved
JustAMan
JustAMan approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW @Bond-009 you now have conflicts

@JustAMan JustAMan merged commit e2f6eca into jellyfin:master Feb 18, 2019
@Bond-009 Bond-009 deleted the fields branch July 24, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bond-009 @JustAMan @joshuaboniface