Improved Docker pkgbuild #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26ed9d5
to
ceb8b9f
Compare
JustAMan
approved these changes
Feb 6, 2019
nvllsvm
requested changes
Feb 9, 2019
There was a problem hiding this comment.
No particular changes necessary, but need some discussion.
Also, have a look at https://docs.docker.com/samples/library/buildpack-deps/
81fd4c1
to
7be4a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleans up the 3 main Docker package builds (Debian, Fedora, and CentOS), and adds a 4th Ubuntu one, to use a reproducible Docker+Script build method, similar to how jellyfin/jellyfin-android works. The built Docker image is thus reusable, and can be kept around by passing the
-k/--keep-artifactsargument first tobuild, thus allowing one to skip most of the environment setup when rebuilding if desired. This also fixes up a couple problems with the Fedora (and CentOS) builds as originally suggested in #806.Issues
N/A