[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more compile time warnings #716

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Remove more compile time warnings #716

merged 1 commit into from
Jan 29, 2019

Conversation

Bond-009
Copy link
Member

Still trying to get to 0.

joshuaboniface
joshuaboniface approved these changes Jan 26, 2019
View reviewed changes
Copy link
Member
@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as part of a mass test of #709, #710, #711, #718, #721, and #723.

Looks good to me.

@hawken93
Copy link
Contributor

Yes, most of the stuff that I didn't know how to fix :) 👍

JustAMan
JustAMan reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All except subtitle changes I understand. Please explain subs!

Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs Show resolved Hide resolved
MediaBrowser.Providers/Subtitles/SubtitleManager.cs Show resolved Hide resolved
JustAMan
JustAMan approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustAMan JustAMan merged commit c8cb908 into jellyfin:master Jan 29, 2019
@Bond-009 Bond-009 deleted the warnings branch January 29, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@JustAMan JustAMan JustAMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bond-009 @hawken93 @JustAMan @joshuaboniface