Respect cancellation token/HTTP request aborts correctly in SymlinkFollowingPhysicalFileResultExecutor
#13033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowingPhysicalFileExecutor
crobibero
reviewed
Nov 15, 2024
Jellyfin.Server/Infrastructure/SymlinkFollowingPhysicalFileResultExecutor.cs
Show resolved
Hide resolved
crobibero
approved these changes
Nov 15, 2024
Shadowghost
approved these changes
Nov 15, 2024
Bond-009
approved these changes
Nov 15, 2024
This was referenced Nov 16, 2024
|
Just leaving a note to say that this did not fix #12456, still pending investigations. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Respects cancellation tokens/HTTP request aborts correctly in
SymlinkFollowingPhysicalFileResultExecutorto ensure that files don't continue being read after the request has been aborted/cancelled.Issues
Fixes #13029, #11343 (maybe #12456 also)
Overrides #12641