Fix subtitle and attachment extraction when input path contains quotes #12575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably also related: #12450 I've seen the path being escaped twice in that CLI |
FFmpeg is complaining about bad format, but I don't see double escaping in the command from that issue. Quotes in the input path will cause problems though. |
Then that is really weird because, the cli itself is fine if there is no quote issues. |
nielsvanvelzen
approved these changes
Sep 7, 2024
nyanmisaka
approved these changes
Sep 7, 2024
Bond-009
approved these changes
Sep 7, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Sep 7, 2024
Fix subtitle and attachment extraction when input path contains quotes Original-merge: 3c3ebe8 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IMediaEncoder.GetInputArgumentto escape input path, as inExtractTextSubtitle.inputPathinExtractTextSubtitleInternalis already escaped.IMediaEncoder.GetInputArgumentto escape input path, as inExtractAttachment.Issues
Fixes #10991
#12450
Fixes #12570