[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix options passed to the linker #467

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fix options passed to the linker #467

merged 1 commit into from
Dec 26, 2022

Conversation

Hind-M
Copy link
Member
@Hind-M Hind-M commented Dec 5, 2022

TODO
Merge with main and check help after merging #465

@JohanMabille
Copy link
Member

@Hind-M Can you rebase this one on main and force push after checking the help of magics please?

@Hind-M
Copy link
Member Author
Hind-M commented Dec 5, 2022

@Hind-M Can you rebase this one on main and force push after checking the help of magics please?

Done.

@JohanMabille JohanMabille merged commit 7568188 into jupyter-xeus:main Dec 26, 2022
@ghost ghost mentioned this pull request Mar 24, 2023
Open
@ghost
Copy link
ghost commented Oct 10, 2023

This PR breaks optional linker arguments.
Only -fsanitize and -g are supported in v0.15 but v0.14 supports custom arguments like -l.
Is this intentional?
#477

@JohanMabille
Copy link
Member

This is not intentional, it is a regression. We are a bit swamped at the moment, so a PR to fix it would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hind-M @JohanMabille