IPv6 strings with an inet6_ntoa #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| @@ -228,6 +234,35 @@ def inet_ntoa(addr): | |||
| addr = addr >> 8 | |||
| return dq | |||
|
|
|||
| def inet6_ntoa(addr): | |||
There was a problem hiding this comment.
I think this is overly complicated. An approach with struct.unpack and an array of bytes along with your compacting regex would be a lot less code and still eliminate netaddr dependency. The struct module is also a python stdlib. Something like:
s = ":".join(["%x"%x for x in unpack(">HHHHHHHH", rawaddr)])
s = re.sub(r'(^|:)0:(0:)+', r'::', s, 1)|
ok; I haven't gotten unpack to work yet but I'll keep trying. |
|
Forgot to note it earlier: this PR will be to fix #380 . |
|
@drzaeus77 something like this? (using a pack to make the bytearray, then an unpack): |
|
That looks better. If addr were a byte[] then the pack("QQ" could be avoided, but this version works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a simple implementation of an inet6_ntoa() in tcpconnect. If this proves suitable, we can move it to bcc init..py.
Known shortcomings: requires "re" package (on my systems that's usually there, whereas netaddr usually isn't). Also doesn't shorten maximum run, so is RFC4291 but not RFC5952 (missing 4.2.1), however, most of the time it is producing RFC5952 addresses. I think it works fine for now, but someone later might drop in a better Python implementation.