Fix Detox failure for new ignited projects #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
approved these changes
Oct 22, 2021
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 22, 2021
# [7.6.0](v7.5.0...v7.6.0) (2021-10-22) ### Bug Fixes * **generators:** Update NAME.tsx.ejs to avoid require cycle ([#1794](#1794) by [@anhtuank7c](https://github.com/anhtuank7c)) ([24d149c](24d149c)) * **tests:** Fix Detox failure for new ignited projects ([#1808](#1808) by [@derekgreenberg](https://github.com/derekgreenberg) and [@glesperance](https://github.com/glesperance)) ([13d9bbb](13d9bbb)) ### Features * **boilerplate:** Update iOS Deployment Target to 11.0 ([#1788](#1788) by @Andrewngabriel) ([e39d3cb](e39d3cb))
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
This fixes a current issue whereby running e2e via Detox failed because the default Detox config did NOT specify which OS of the iPhone 11 device is used for e2e tests. The change is to
package.json. Instead of merely specifying the name of the iOS simulated device, both the name and OS version are specified. The OS version in this case must be less than 15 in order to avoid the cause of Detox tests failing on new ignited projects.To provide more information about how users can configure the Detox settings in
package.jsonaccording to their environment, the README file in the e2e directory has been updated with information about how to find the supported versions of simulators installed in their environments via Xcode itself. This will help future users modify the Detox configuration settings in the future.Fixes #1804.