Update norm function in transform.py #6366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added default behaviour when values to normalize are all equal; if they are all 0 then all values are set to 0, otherwise all values are set to 1
|
Can you explain why this is needed? |
|
Sure ! I ran into this error because I'm working on xarray datasets with multiple variables and procedurally creating vectorfields for each variable. I'm controlling the scale of the vectors using .opts(magnitude=hv.dim("Magnitude").norm()) |
|
I'm not opposed to this PR, but currently, it breaks CI. Did you try to pass in limits to Would you happen to have a small example I could play around with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature / Bug Fix
Added default behaviour when values to normalize are all equal; previously holoviews would attempt division by zero and return a runtime warning.
Proposed change : if all values are equal to zero, set all values to 0; otherwise, set all values to 1.