-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Using Private Data in Fabric' tutorial #1875
Conversation
e919c4d
to
4123c6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits. @denyeart have you (or do you know whether any of the maintainers have) tested the tutorial?
4123c6e
to
b34deb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2489
The tutorial should eventually contain the asset transfer flow that is contained in the readme here: https://github.com/hyperledger/fabric-samples/tree/master/asset-transfer-private-data/chaincode-go. Eventually we should aim to remove that readme and link to the tutorial. If the tutorial works from e2e, I am ok merging it and iterating from there, so that we are away from the dependency on the old private data smart contract. I think we can also replace the commands to use the chaincode lifecycle with the command to deploy using the test network script to shorten the tutorial, but that can also follow later. |
The transfer flow is included in the purge private data section. I can specifically call it out with it’s own header.
…Sent from my iPhone
On Sep 14, 2020, at 8:24 AM, nikhil550 ***@***.***> wrote:
The tutorial should eventually contain the asset transfer flow that is contained in the readme here: https://github.com/hyperledger/fabric-samples/tree/master/asset-transfer-private-data/chaincode-go. Eventually we should aim to remove that readme and link to the tutorial. If the tutorial works from e2e, I am ok merging it and iterating from there, so that we are away from the dependency on the old private data smart contract.
I think we can also replace the commands to use the chaincode lifecycle with the command to deploy using the test network script to shorten the tutorial, but that can also follow later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
It worked for me e2e, I tested it twice before I pushed it. I welcome peer review testing though.
…Sent from my iPhone
On Sep 14, 2020, at 8:24 AM, nikhil550 ***@***.***> wrote:
The tutorial should eventually contain the asset transfer flow that is contained in the readme here: https://github.com/hyperledger/fabric-samples/tree/master/asset-transfer-private-data/chaincode-go. Eventually we should aim to remove that readme and link to the tutorial. If the tutorial works from e2e, I am ok merging it and iterating from there, so that we are away from the dependency on the old private data smart contract.
I think we can also replace the commands to use the chaincode lifecycle with the command to deploy using the test network script to shorten the tutorial, but that can also follow later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the addition of the two Pipfile's? Especially the one in the root of the repo?
That was a local doc build accident. I’ll clean it up when addressing the latest comments.
…Sent from my iPhone
On Sep 14, 2020, at 9:14 AM, Brett Logan ***@***.***> wrote:
@btl5037 requested changes on this pull request.
Why the addition of the two Pipfile's? Especially the one in the root of the repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
b34deb2
to
7571fc0
Compare
I added an asset transfer header, to specifically call this out. The original direction was to integrate the private data README into the existing tutorial which I took to mean that we wanted to keep the flow of the tutorial. We can certainly just adopt the README flow as well and drop the peer chaincode lifecycle piece in favor of the script approach to make it shorter, but I agree we should merge for now and do that in another PR. |
I agree that we need to maintain the current flow of the tutorial, at least in terms of keeping the technical sections. we can work to integrate and improve the flow until the readme is redundant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran fine on my computer. I have some comments on the flow in addition to the existing comments. Ill let you address, but we may want to merge and iterate and some point.
Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> fix invoke command on first ReadAsset Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> minor grammatical fixes Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> resolve comments Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> Add Asset Transfer section header and delete pipfile Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> address comments and add use case section Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com>
7571fc0
to
cda4a6d
Compare
@btl5037 this has been addressed for some time, please review so we can get merged. |
@Mergifyio backport release-2.2 |
Command
|
…1875) (cherry picked from commit 17858a5) Signed-off-by: Waleed Mortaja <waleedmortaja@protonmail.com> Update 'Using Private Data in Fabric' tutorial Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> fix invoke command on first ReadAsset Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> minor grammatical fixes Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> resolve comments Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> Add Asset Transfer section header and delete pipfile Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> address comments and add use case section Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com>
(cherry picked from commit 17858a5) Signed-off-by: Waleed Mortaja <waleedmortaja@protonmail.com> Update 'Using Private Data in Fabric' tutorial Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> fix invoke command on first ReadAsset Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> minor grammatical fixes Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> resolve comments Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> Add Asset Transfer section header and delete pipfile Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com> address comments and add use case section Signed-off-by: Chris Gabriel <chris_gabriel_98@yahoo.com>
Signed-off-by: Chris Gabriel chris_gabriel_98@yahoo.com
Type of change
Description
This tutorial update integrates the new fabric-samples private data asset transfer README into the existing "Using Private Data in Fabric" tutorial per the direction of the fabric-samples workgroup.