use secrets to generate worker id #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worker ID right now is typically based off the address of an object in memory. This could be guessed. While the worker is tied to a specific IP, there is a chance an off-path attacker could be hosted behind the same IP as the caller. They could possibly guess the worker id of an unclaimed session by observing the sequence of IDs presented to themselves, leading to them gaining access to an already authenticated SSH session. Use the python secrets module to generate a cryptographically secure token to use as the worker ID. This shoud be much harder to guess.
Codecov ReportBase: 93.81% // Head: 93.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 93.81% 93.29% -0.52%
==========================================
Files 6 6
Lines 727 731 +4
Branches 130 130
==========================================
Hits 682 682
- Misses 31 35 +4
Partials 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Merged, but found that Python 2 Python 3.4 Python 3.5 do not have the secrets module. |
Oh! Sorry. I didn't notice. I was going to suggest we do something else if the import fails, but I see you did that in a followup. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker ID right now is typically based off the address of an object in memory. This could be guessed. While the worker is tied to a specific IP, there is a chance an off-path attacker could be hosted behind the same IP as the caller. They could possibly guess the worker id of an unclaimed session by observing the sequence of IDs presented to themselves, leading to them gaining access to an already authenticated SSH session.
Use the python secrets module to generate a cryptographically secure token to use as the worker ID. This should be much harder to guess.