On server, include receiving HTTP/2 settings in handshake timeout #13336

markdroth · 2017-11-09T21:34:23Z

I think this is right, but I'd like confirmation both that (a) it should do the right thing and (b) it's the right way to implement this.

Also, I'd welcome suggestions on how to test this. My first thought was to use the bad_client framework, but it looks like bad_client directly creates a chttp2 transport rather than using the handshaking code from chttp2_server.cc, which is where the handshake timeout is enforced. Would it make sense to modify it to use the handshaking code? Or should I just write an independent test that does something similar? Alternative suggestions welcome.

grpc-testing · 2017-11-09T21:37:41Z

****************************************************************

libgrpc.so

     VM SIZE                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                              ++++++++++++++
  +0.1%    +289 [None]                                                               +14.9Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                   +528   +25%
      [NEW]    +176 on_timeout                                                              +176  [NEW]
       +34%    +129 on_handshake_done                                                       +129   +34%
       +31%     +80 on_accept                                                                +80   +31%
      [NEW]     +71 server_connection_state_unref                                            +71  [NEW]
      [NEW]     +51 on_receive_settings                                                      +51  [NEW]
       +54%     +21 [Unmapped]                                                               +21   +54%
  +0.2%     +51 src/core/ext/transport/chttp2/transport/chttp2_transport.cc              +51  +0.2%
       +27%     +19 grpc_chttp2_transport_start_reading                                      +19   +27%
      +0.5%     +16 grpc_create_chttp2_transport                                             +16  +0.5%
      +4.3%     +10 perform_transport_op_locked                                              +10  +4.3%
      +0.9%      +6 [Unmapped]                                                                +6  +0.9%
  +2.3%     +50 src/core/ext/transport/chttp2/transport/frame_settings.cc                +50  +2.3%
      +4.1%     +50 grpc_chttp2_settings_parser_parse                                        +50  +4.1%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc      +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                  +2  +0.5%

  +0.1%    +920 TOTAL                                                                +15.5Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-09T21:48:16Z

[trickle] No significant performance differences

grpc-testing · 2017-11-09T22:29:04Z

[microbenchmarks] Performance differences noted:
Benchmark                                                                     cpu_time    real_time
----------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/32768                                  -8%         -8%
BM_PumpStreamServerToClient<InProcess>/32768                                  -5%         -5%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/262144          +4%         +4%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768           +6%         +6%
BM_StreamingPingPongMsgs<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/32768  +4%         +4%

markdroth · 2017-11-15T20:49:24Z

Noah, can you please take a look at this, since Craig is out?

Unless you have a better suggestion, I'm thinking of changing the bad_client framework to use the handshaker code so that I can add a test for this functionality.

Thanks!

…_timeout

grpc-testing · 2017-11-15T20:57:32Z

****************************************************************

libgrpc.so

     VM SIZE                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                              ++++++++++++++
  +0.1%    +321 [None]                                                               +14.9Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                   +528   +25%
      [NEW]    +176 on_timeout                                                              +176  [NEW]
       +34%    +129 on_handshake_done                                                       +129   +34%
       +31%     +80 on_accept                                                                +80   +31%
      [NEW]     +71 server_connection_state_unref                                            +71  [NEW]
      [NEW]     +51 on_receive_settings                                                      +51  [NEW]
       +54%     +21 [Unmapped]                                                               +21   +54%
  +0.2%     +51 src/core/ext/transport/chttp2/transport/chttp2_transport.cc              +51  +0.2%
       +27%     +19 grpc_chttp2_transport_start_reading                                      +19   +27%
      +0.5%     +16 grpc_create_chttp2_transport                                             +16  +0.5%
      +4.3%     +10 perform_transport_op_locked                                              +10  +4.3%
      +0.9%      +6 [Unmapped]                                                                +6  +0.9%
  +2.3%     +50 src/core/ext/transport/chttp2/transport/frame_settings.cc                +50  +2.3%
      +4.1%     +50 grpc_chttp2_settings_parser_parse                                        +50  +4.1%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc      +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                  +2  +0.5%

  +0.1%    +952 TOTAL                                                                +15.5Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-15T21:07:52Z

[trickle] No significant performance differences

grpc-testing · 2017-11-15T21:50:28Z

[microbenchmarks] No significant performance differences

ncteisen · 2017-11-17T03:23:20Z

Let's talk tomorrow (or after break) about how best to test this. I think we are in need of a method or framework (maybe) to test chttp2 edge cases. I am running into that problem trying to test a fix for #13062. That PR will end up doing a similar thing to this, and I will build off this.

…_timeout

grpc-testing · 2017-11-20T20:38:20Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +294 [None]                                                                +15.6Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +176 on_timeout                                                               +176  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +54%     +21 [Unmapped]                                                                +21   +54%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
       +15%     +37 perform_transport_op_locked                                               +37   +15%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +896 TOTAL                                                                 +16.2Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++

 -------------- SHRINK --------------
  [ = ]       0 [None]     -48  -0.0%

  [ = ]       0 TOTAL      -48  -0.0%

grpc-testing · 2017-11-20T20:50:53Z

[trickle] No significant performance differences

grpc-testing · 2017-11-20T21:30:40Z

[microbenchmarks] No significant performance differences

markdroth · 2017-11-21T23:48:52Z

I've added a test here that I think verifies that the change works as required. PTAL. Thanks!

grpc-testing · 2017-11-21T23:50:47Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +294 [None]                                                                +19.5Ki  +0.4%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +176 on_timeout                                                               +176  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +54%     +21 [Unmapped]                                                                +21   +54%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
       +15%     +37 perform_transport_op_locked                                               +37   +15%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +896 TOTAL                                                                 +20.1Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-22T00:02:29Z

[trickle] No significant performance differences

grpc-testing · 2017-11-22T00:42:27Z

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_InProcessCHTTP2_NoOpMutator_NoOpMutator__0_64.opt.old: 1


[microbenchmarks] Performance differences noted:
Benchmark                                            cpu_time    real_time
---------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/32768         +4%         +4%
BM_PumpStreamClientToServer<InProcessCHTTP2>/262144  +4%         +4%

grpc-testing · 2017-11-27T16:35:15Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +294 [None]                                                                +19.5Ki  +0.4%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +176 on_timeout                                                               +176  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +54%     +21 [Unmapped]                                                                +21   +54%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
       +15%     +37 perform_transport_op_locked                                               +37   +15%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +896 TOTAL                                                                 +20.1Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2017-11-29T20:07:54Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +294 [None]                                                                +19.5Ki  +0.4%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +162 on_timeout                                                               +162  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +90%     +35 [Unmapped]                                                                +35   +90%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
       +15%     +37 perform_transport_op_locked                                               +37   +15%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +896 TOTAL                                                                 +20.1Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +72  +0.0%

  [ = ]       0 TOTAL      +72  +0.0%

grpc-testing · 2017-11-29T20:20:22Z

[trickle] No significant performance differences

grpc-testing · 2017-11-29T20:29:51Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-11-29T20:59:59Z

[microbenchmarks] Performance differences noted:
Benchmark                                           cpu_time    real_time
--------------------------------------------------  ----------  -----------
BM_PumpStreamServerToClient<InProcessCHTTP2>/32768  -6%         -6%

…_timeout

grpc-testing · 2017-12-01T17:00:02Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.0%    +294 [None]                                                                +15.6Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +162 on_timeout                                                               +162  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +90%     +35 [Unmapped]                                                                +35   +90%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
      [NEW] +3.43Ki grpc_create_chttp2_transport                                          +3.43Ki  [NEW]
      [NEW]    +100 grpc_chttp2_transport_start_reading                                      +100  [NEW]
       +15%     +37 perform_transport_op_locked                                               +37   +15%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +896 TOTAL                                                                 +16.2Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +72  +0.0%

  [ = ]       0 TOTAL      +72  +0.0%

grpc-testing · 2017-12-01T17:11:20Z

[trickle] No significant performance differences

grpc-testing · 2017-12-01T17:53:03Z

[microbenchmarks] No significant performance differences

ctiller · 2017-12-04T15:49:16Z

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

-    close_transport_locked(exec_ctx, t, close_transport);
+  if (op->disconnect_with_error != GRPC_ERROR_NONE) {
+    close_transport_locked(exec_ctx, t, op->disconnect_with_error);
+    if (t->notify_on_receive_settings != nullptr) {


why isn't this in close_transport_locked?

Yeah, that does look like a better place for it. Done.

grpc-testing · 2017-12-04T16:49:41Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +326 [None]                                                                +19.6Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +162 on_timeout                                                               +162  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +90%     +35 [Unmapped]                                                                +35   +90%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
      [NEW] +3.45Ki grpc_create_chttp2_transport                                          +3.45Ki  [NEW]
      [NEW]    +100 grpc_chttp2_transport_start_reading                                      +100  [NEW]
      +4.5%     +32 close_transport_locked                                                    +32  +4.5%
      +0.5%      +3 [Unmapped]                                                                 +3  +0.5%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +928 TOTAL                                                                 +20.2Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +72  +0.0%

  [ = ]       0 TOTAL      +72  +0.0%

grpc-testing · 2017-12-04T17:03:10Z

[trickle] No significant performance differences

grpc-testing · 2017-12-04T17:18:54Z

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +0.1%    +326 [None]                                                                +19.6Ki  +0.3%
   +25%    +528 src/core/ext/transport/chttp2/server/chttp2_server.cc                    +528   +25%
      [NEW]    +162 on_timeout                                                               +162  [NEW]
       +34%    +129 on_handshake_done                                                        +129   +34%
       +31%     +80 on_accept                                                                 +80   +31%
      [NEW]     +71 server_connection_state_unref                                             +71  [NEW]
      [NEW]     +51 on_receive_settings                                                       +51  [NEW]
       +90%     +35 [Unmapped]                                                                +35   +90%
  +1.8%     +39 src/core/ext/transport/chttp2/transport/frame_settings.cc                 +39  +1.8%
      +3.2%     +39 grpc_chttp2_settings_parser_parse                                         +39  +3.2%
  +0.1%     +25 src/core/ext/transport/chttp2/transport/chttp2_transport.cc               +25  +0.1%
      [NEW] +3.45Ki grpc_create_chttp2_transport                                          +3.45Ki  [NEW]
      [NEW]    +100 grpc_chttp2_transport_start_reading                                      +100  [NEW]
      +4.5%     +32 close_transport_locked                                                    +32  +4.5%
      +0.5%      +3 [Unmapped]                                                                 +3  +0.5%
  +1.6%      +8 src/core/ext/transport/chttp2/client/insecure/channel_create_posix.cc      +8  +1.6%
      +1.6%      +8 grpc_insecure_channel_create_from_fd                                       +8  +1.6%
  +0.5%      +2 src/core/ext/transport/chttp2/server/insecure/server_chttp2_posix.cc       +2  +0.5%
      +0.5%      +2 grpc_server_add_insecure_channel_from_fd                                   +2  +0.5%

  +0.1%    +928 TOTAL                                                                 +20.2Ki  +0.3%


****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +72  +0.0%

  [ = ]       0 TOTAL      +72  +0.0%

grpc-testing · 2017-12-04T17:30:29Z

[trickle] No significant performance differences

grpc-testing · 2017-12-04T17:41:11Z

[microbenchmarks] No significant performance differences

grpc-testing · 2017-12-04T18:11:11Z

[microbenchmarks] No significant performance differences

markdroth · 2017-12-04T22:28:23Z

Known failures: #13148 #12917 #12510

Apply #13336 to v1.8.x branch.

Apply #13336 to v1.7.x branch.

markdroth added 5 commits November 9, 2017 07:58

Add channel arg for server handshake timeout.

fbc3f04

Bool-ify is_client param.

bcfd0f3

Add notify_on_receive_settings closure to chttp2 transport.

04c97d0

Remove declaration of non-existant function.

8eeedab

Use notify_on_receive_settings to enforce server handshake deadline.

faeabff

markdroth assigned ctiller Nov 9, 2017

markdroth requested a review from ctiller November 9, 2017 21:34

googlebot added the cla: yes label Nov 9, 2017

markdroth requested a review from ncteisen November 15, 2017 20:48

Merge remote-tracking branch 'upstream/master' into server_connection…

03610f6

…_timeout

markdroth added 2 commits November 20, 2017 12:34

Fix some dumb typos.

e36d9ea

Merge remote-tracking branch 'upstream/master' into server_connection…

da6b479

…_timeout

Add test for handshake timeout.

b9f34ac

clang-format

aaad0c2

Merge remote-tracking branch 'upstream/master' into server_connection…

e109ddf

…_timeout

ctiller reviewed Dec 4, 2017

View reviewed changes

Move chttp2 cleanup code into close_transport_locked().

a92428b

ctiller approved these changes Dec 4, 2017

View reviewed changes

generate_projects.sh

2c619be

markdroth merged commit 6fa206d into grpc:master Dec 4, 2017

markdroth deleted the server_connection_timeout branch December 4, 2017 22:28

markdroth added a commit to markdroth/grpc that referenced this pull request Dec 5, 2017

Apply grpc#13336 to v1.8.x branch.

e204e5e

mehrdada added a commit that referenced this pull request Dec 5, 2017

Merge pull request #13641 from markdroth/server_connection_timeout_1.8

7e75853

Apply #13336 to v1.8.x branch.

markdroth added a commit to markdroth/grpc that referenced this pull request Dec 5, 2017

Apply grpc#13336 to v1.7.x branch.

3757581

markdroth added a commit that referenced this pull request Dec 5, 2017

Merge pull request #13642 from markdroth/server_connection_timeout_1.7

e78bd13

Apply #13336 to v1.7.x branch.

This was referenced Dec 6, 2017

Apply #13336 to v1.7.x branch. #13642

Merged

Apply #13336 to v1.8.x branch. #13641

Merged

markdroth mentioned this pull request Jan 25, 2018

Decrease verbosity of backup poller shutdown message #14180

Closed

lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On server, include receiving HTTP/2 settings in handshake timeout #13336

On server, include receiving HTTP/2 settings in handshake timeout #13336

On server, include receiving HTTP/2 settings in handshake timeout #13336

On server, include receiving HTTP/2 settings in handshake timeout #13336

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment