[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flavor and build types fallback logic #31

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

mohamadk
Copy link
Contributor
@mohamadk mohamadk commented Sep 30, 2022

Adding flavors and build types fallback logic

using the project app module variants as the base for creating all bazel build targets of all modules.

fallback logics come to play when a dependency doesn't have a flavor or buildType or both that exist in the app module, in that case, fallbacks are used to select a substitute variant from existing variants in the dependency

for example in the following build graph
app -> B -> C

app - with flavors[f1,f2] buildTypes[ debug, release ]
B - android Lib buildTypes [ debug , release ]
C - kotlin / java lib

for module B bazel targets will be created for B according to the app module

bf1Debug // which is equal to original debug variants in B
bf2Debug // which is equal to original debug variants in B
bf1Release // which is equal to original Release variants in B
bf2Release // which is equal to original Release variants in B

the reason for this is to create the dependency graph in bazel for all app module variants.

@minkuan88 minkuan88 merged commit 608cac7 into grab:master Sep 30, 2022
akshay-grabtaxi pushed a commit that referenced this pull request Jun 28, 2023
* add support for flavor fallbacks and build types fallbacks

Co-authored-by: mohammad.khaleghi <mohammad.khaleghi@grabtaxi.com>
akshay-grabtaxi pushed a commit that referenced this pull request Jun 28, 2023
* add support for flavor fallbacks and build types fallbacks

Co-authored-by: mohammad.khaleghi <mohammad.khaleghi@grabtaxi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants