[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced subtitle DASH support checking for wrong Role@value #9727

Closed
theRealRobG opened this issue Nov 24, 2021 · 2 comments
Closed

Forced subtitle DASH support checking for wrong Role@value #9727

theRealRobG opened this issue Nov 24, 2021 · 2 comments
Assignees
@icbaker
Labels
bug

Comments

@theRealRobG
Copy link

When checking for forced subtitle behaviour in the DashManifestParser.java, the Role@value being matched against is forced_subtitle:
https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1477
https://github.com/google/ExoPlayer/blob/r2.16.1/library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java#L1547

But according to the 4th edition of ISO/IEC 23009-1 (publicly available here) this should be checking for forced-subtitle. This is defined in Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011":

Role@value Description Applicable Media Type(s) (Informative)
forced-subtitle Textual information meant for display when no other text representation is selected. It is used to clarify dialogue, alternate languages, texted graphics or location/person IDs that are not otherwise covered in the dubbed/localized audio. text

Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011"
@theRealRobG theRealRobG mentioned this issue Nov 25, 2021
Open
@icbaker icbaker self-assigned this Nov 25, 2021
@icbaker
Copy link
Collaborator
icbaker commented Nov 25, 2021

Thanks for pointing this out - as you've probably realised, we added support for this after it was requested in #8781 and we used forced_subtitled based on this comment from April 2018: Dash-Industry-Forum/DASH-IF-IOP#165 (comment)

Given you've mentioned later in that thread that Shaka have have also done the same thing, I suspect there will now be content out there with a mix of the two spellings :( It's probably best for now if I update ExoPlayer to support both spellings - so that content that used to work with ExoPlayer (with the 'wrong' spelling) will keep working. I'll make that change.

@theRealRobG
Copy link
Author

Yes, makes sense as a pragmatic approach.

Thanks for quick reply!

kim-vde pushed a commit that referenced this issue Nov 26, 2021
@icbaker @kim-vde
Parse DASH forced-subtitle role value
276f103 
Issue: #9727

#minor-release

PiperOrigin-RevId: 412266397
@icbaker icbaker closed this as completed Nov 26, 2021
tonihei pushed a commit to androidx/media that referenced this issue Dec 2, 2021
@icbaker @tonihei
Parse DASH forced-subtitle role value
a4c12ca 
Issue: google/ExoPlayer#9727

#minor-release

PiperOrigin-RevId: 412266397
@icbaker icbaker mentioned this issue Dec 20, 2021
Closed
@google google locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@icbaker icbaker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icbaker @theRealRobG