Improve run instances UX: avoid removing data and add a clear popup. #99649
+61
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Nov 24, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
However, when you restart the editor, all instances are back to the highest number of instances you've ever defined.
This means that for example, if you create 2 instances (having 3 in total), fill their arguments, reduce the instance count to 1, save and restart the editor, you'll see all 3 instances again once you restart the editor. This applies even after using right-click > Clear All.
d188c8c
to
71d0082
Compare
|
Had to add a new project metadata entry to keep the value, because before we were just relying on the size of the list's size for the instance count field, but since now we're keeping all the data it's not really possible to do this without storing the number somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the experience of using the "Run Instances" dialog by not aggressively resizing the internal structures, I was bitten by this multiple times when testing things that require multiple instances with different parameters: If I have the dialog set up with 4 instances with different parameters but I want to run two instances temporarily for a different test, lowering the number deletes all the data in the rows that are gone, so when I go back to the old number I'd have to set it up again.
To make it a bit easier to remove things if, for example, the user creates a ton of different params and wants to go back, I've added a right click menu with the option to clear a single line in the tree or to clear everything, I think that should cover the more common use cases.
Here's a video of it in action:
behavior_demo.mp4