fix(patch/v25.2): dereference outputs ctn config (#614)

go-vela · Nov 1, 2024 · 0f0deb2 · 0f0deb2
1 parent 964d7a1
commit 0f0deb2
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/cmd/vela-worker/exec.go b/cmd/vela-worker/exec.go
@@ -146,8 +146,11 @@ func (w *Worker) exec(index int, config *api.Worker) error {
 		break
 	}
 
-	// set the outputs container ID
-	w.Config.Executor.OutputCtn.ID = fmt.Sprintf("outputs_%s", p.ID)
+	// dereference configured outputs ctn config and set the outputs container ID for the executor
+	//
+	// need to dereference to avoid executors sharing the last set outputs container config
+	execOutputCtn := *w.Config.Executor.OutputCtn
+	execOutputCtn.ID = fmt.Sprintf("outputs_%s", p.ID)
 
 	// create logger with extra metadata
 	//
@@ -240,7 +243,7 @@ func (w *Worker) exec(index int, config *api.Worker) error {
 		Build:               item.Build,
 		Pipeline:            p.Sanitize(w.Config.Runtime.Driver),
 		Version:             v.Semantic(),
-		OutputCtn:           w.Config.Executor.OutputCtn,
+		OutputCtn:           &execOutputCtn,
 	})
 
 	// add the executor to the worker