[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File instances for all PyGRB postprocessing input #4894

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pannarale
Copy link
Contributor
@pannarale pannarale commented Sep 26, 2024

This PR is a continuation of the work started in #4891.

  • The labels_in_files_metadata function introduced in the previous PR has an additional argument for the run directory path.
  • All input files (found triggers, injections results, template bank) are converted to File instances.
  • Some minor cleanup is carried out: the definition of the out_dirs_dict dictionary is moved and the repeated operation of determining the variable inj_sets is performed only once.

Standard information about the request

This brings master closer to producing a full results webpage as in this example.

This change affects: PyGRB.

This change changes: result presentation / plotting.

Testing performed

As for the previous PR, the complete set of changes will produce the end result linked above, but this single PR will enable only part of it and does not have stand alone examples/tests.

Additional notes

As a reminder, the plan is to run black at the very end of this set of PRs.

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale added the PyGRB PyGRB development label Sep 26, 2024
@pannarale pannarale self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant