CI changes to use split_binned hist #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98b8a2e
to
c638a43
Compare
spxiwh
approved these changes
Dec 12, 2023
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Dec 19, 2023
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
GarethCabournDavies
added a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Dec 19, 2023
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
maxtrevor
pushed a commit
to maxtrevor/pycbc
that referenced
this pull request
Jan 16, 2024
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* CI changes to use split_binned hist * change back to mtotal now that is fixed by gwastro#4577 * revert related but unnecessary change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are mainly using
pycbc_fit_sngls_split_binnedrather thanpycbc_fit_sngls_binnedin the workflow, this changes the CI to use that code rather than the un-split version.Note I have had to change from mtotal to mchirp due to the error fixed in #4577