[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in gl-430/debug and gl-430/texture-view #23

Closed
wants to merge 2 commits into from

Conversation

dvelasquez1987
Copy link

Hello,

The changes have the respective comments, basically are the following:

gl-430/texture-view - Vertex shader error, precision qualifier can't be used in constructor.

gl-430/debug - Wrong parameter passed into glObjectLabel, A pipeline generated name can’t be used for a vertex program object. Also, a name of a buffer can’t be used if the object has not been created, that happens when the object is bind.

Thanks,

-Diego

precision qualifier can't be use in constructor.

Precision qualifier only can be in
- Variable declaration
- Function return type
- Function parameter

GLSL spec 4.4, chapeter 4.7, section 2, page 83 said:

"Precision qualifiers, as with other qualifiers, do not effect the basic
type of the variable. In particular, there are no constructors for
precision conversions; constructors only convert types. Similarly,
precision qualifiers, as with other qualifiers, do not contribute to
function overloading based on parameter types. As discussed in the next
chapter, function input and output is done through copies, and therefore
qualifiers do not have to match."
A pipeline generated name can be use for vertex program object.

OpenG spec 4.4, chapeter 20.7, page 501 said:

"identifier must be one of the tokens in table 20.4, indicating the type
of the object corresponding to name"

Since the above needs to match the name needs to be created already, that
means that needs to be bind before calling glObjectLabel.
@Groovounet Groovounet closed this Feb 10, 2014
@dvelasquez1987
Copy link
Author

Hi Groovounet,

The gl-430/texture-view, I see that is fixed, but in the other hand gl-430/gl-430-debug.cpp is not. The sample still wrong against spec. Do you have any comments? or do I miss anything?

Thanks,
-Diego

@Groovounet
Copy link
Member

I have further work I am planing to do on gl-430-debug.cpp so just ignore that sample for the moment. ;)

I am going to make it a sample that generates errors and that will be the way it succeed.

But please have a look at the other samples of branch 4.4.1. :D

@dvelasquez1987
Copy link
Author

:) sounds good though.. sure I will take a look at it, and if I have any comments I will let you know.

Thanks,
-Diego

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants