fix: enable revm/blst
#8965
Merged
fix: enable revm/blst
#8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
approved these changes
Sep 26, 2024
6833c2f
to
bc37168
Compare
mattsse
requested changes
Sep 26, 2024
There was a problem hiding this comment.
we currently enable all the revm features in the crates, I think we should be consistent and also do this for anvil and the evm crate instead because this only really matters there?
ref revm = {
wdyt @DaniPopes
|
Yeah I'd prefer that, foundry-evm should be enough |
|
moved to evm-core as this is where we create EVM and configure the spec |
DaniPopes
approved these changes
Sep 26, 2024
mattsse
approved these changes
Sep 26, 2024
|
error unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we need this feature to enable BLS precompiles for prague and alphanet spec
Solution