[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Makefile and codespell #8948

Merged
merged 7 commits into from
Sep 24, 2024
Merged

chore: add Makefile and codespell #8948

merged 7 commits into from
Sep 24, 2024

Conversation

zerosnacks
Copy link
Member
@zerosnacks zerosnacks commented Sep 24, 2024 •
edited
Loading

Motivation

Adds a Makefile to help run the various command locally more easily

$ make yields:

Usage:
  make <target>

Help
  help             Display this help.

Build
  build            Build the project.

Other
  clean            Clean the project.
  fmt              Run all formatters.
  lint             Run all linters.
  test             Run all tests.
  pr               Run all tests and linters in preparation for a PR.

Includes common tasks focused on commands you would run for a PR

Adds codespell to Makefile and CI (also used by Reth) to enforce spell checking

Solution

No breaking changes, fixes spelling issues raised by codespell

@zerosnacks zerosnacks marked this pull request as ready for review September 24, 2024 11:51
@zerosnacks zerosnacks changed the title chore: add Makefile and codespell chore: add Makefile and codespell to CI Sep 24, 2024
@zerosnacks zerosnacks changed the title chore: add Makefile and codespell to CI chore: add Makefile and codespell Sep 24, 2024
mattsse
mattsse approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo farmers in shambles

DaniPopes
DaniPopes reviewed Sep 24, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
DaniPopes
DaniPopes reviewed Sep 24, 2024
View reviewed changes
.codespellrc Outdated Show resolved Hide resolved
@zerosnacks zerosnacks merged commit b09a88b into master Sep 24, 2024
21 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/add-makefile branch September 24, 2024 15:39
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
@zerosnacks @rplusq
chore: add Makefile and codespell (foundry-rs#8948)
8528738 
* add makefile + codespell

* update makefile

* fix typos found by codespell

* add codespell CI task

* fix outdated spec

* ignore testdata

* switch default profile to dev, add strat to ignored words list
@elfedy elfedy mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArkFunds ArkFunds ArkFunds approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zerosnacks @mattsse @DaniPopes @ArkFunds