[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom_calyptia: honour collector interval in secs and nano secs. #9648

Merged
merged 2 commits into from
Nov 27, 2024
Merged

custom_calyptia: honour collector interval in secs and nano secs. #9648

merged 2 commits into from
Nov 27, 2024
+330 −99

Conversation

niedbalski
Copy link
Collaborator

Description

This change makes the custom calyptia plugin honour the configured collector
interval (both in secs and nanosecs) that is cascaded to the instantiated input fleet plugin.

Also, I took the chance to add unit test to validate the cascade of properties to the underlying
fleet plugin.

Testing

  • Example configuration file for the change
[SERVICE]
    log_level trace

[CUSTOM]
    Name calyptia
    API_Key xxxx.xxxx
    fleet_id e01085df-49d1-451d-b89f-226cd381369c
    Calyptia_Host cloud-api.calyptia.com
    fleet.interval_sec 120
  • Debug log output from testing the change

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@niedbalski niedbalski self-assigned this Nov 26, 2024
@niedbalski niedbalski marked this pull request as ready for review November 26, 2024 15:03
@edsiper
Copy link
Member
edsiper commented Nov 26, 2024

@niedbalski Since the PR and commits touch different components, we need, as a minimum for this case 2 commits, one per plugin, ref: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes . This is to have a clean history and log per component.

As soon as the commits are fixed we can merge it.

@edsiper edsiper added this to the Fluent Bit v3.2.2 milestone Nov 26, 2024
cosmo0920

This comment was marked as outdated.

Sign in to view

cosmo0920
cosmo0920 requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor
@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've overlooked that this PR touches the different components in the same commit.
We have to split commits and commit again with the same groups.
The changes should be reasonable. Just commit issue.

@edsiper edsiper merged commit 6ba1121 into master Nov 27, 2024
49 of 50 checks passed
@edsiper edsiper deleted the fix/fleet-interval branch November 27, 2024 14:11
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecaros lecaros Awaiting requested review from lecaros

@cosmo0920 cosmo0920 Awaiting requested review from cosmo0920

Assignees

@niedbalski niedbalski

Labels
None yet
Projects
None yet
Milestone
Fluent Bit v3.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@niedbalski @edsiper @cosmo0920 @lecaros