Fix sqa storage issue for input_constructors #2791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
f0d695e
to
8c5b810
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
8c5b810
to
417e857
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
417e857
to
92eea09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 490 490
Lines 48413 48437 +24
=======================================
+ Hits 46342 46366 +24
Misses 2071 2071 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
46eab37
to
9b2adaa
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Differential Revision: D63442156
9b2adaa
to
fb89696
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D63442156
fb89696
to
dcef8d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D63442156
dcef8d3
to
01a0eb6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
Summary: Pull Request resolved: facebook#2791 I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this. Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D63442156
|
This pull request was exported from Phabricator. Differential Revision: D63442156 |
01a0eb6
to
2e9e360
Compare
|
This pull request has been merged in e09033c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I recently added storage for input constructors, and our json tests pass for this because json is able to eloquently handle the enum of inputconstructorpurpose since the enum value is a string, however, it looks like sqa storage is not able to do this.
Differential Revision: D63442156