Prevent Espanso Sync Tool window from stealing focus. #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ec1285
to
bd25b6b
Compare
Removing call to `xdg_activation` should prevent the sync tool window from stealing focus for compositors which support the xdg_activation protocol. Tested under Hyprland/wlroots and appears to resolve issue, but more testing should be performed before merging.
|
I'm unsure why clippy is failing on macos/windows build. No changes have been made there. |
|
Prolly because clippy receives updates every few months and we use stable rust (not pinned). So to keep up we need to fix the "new" lints. This happens to fail when the CI is run with latest rust |
|
Hi! I fixed clippy and forgot to tell you 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1976
Removing call to
xdg_activationshould prevent the sync tool window from stealing focus for compositors which support the xdg_activation protocol.Tested under Hyprland/wlroots and appears to resolve issue, but more testing should be performed before merging.