[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix multi-version parsing in issue assignment #44679

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: fix multi-version parsing in issue assignment #44679

wants to merge 2 commits into from
+31 −25

Conversation

codebytere
Copy link
Member

Description of Change

Fixes an issue where issues opened against Electron would fail to auto-assign versions if more than one was provided. All relevant versions should be assigned to the issue if more than one is provided.

Before:

// Using 34.0.0-alpha.6, 33.0.2, 32.2.2, 31.7.3
const major = semver.parse(electronVersion)?.major; // undefined, no versions

After:

// Using 34.0.0-alpha.6, 33.0.2, 32.2.2, 31.7.3
const major = semver.parse(electronVersion)?.major; // 34, 33, 32, 31

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/none target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Nov 15, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2024
dsanders11
dsanders11 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member
@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dsanders11 dsanders11 added no-backport and removed target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Nov 16, 2024
@dsanders11
Copy link
Member

Removed the backport targets since this workflow only runs from main.

nikwen
nikwen reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor
@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a thought that this might be worth including.

.github/workflows/issue-opened.yml Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikwen nikwen nikwen left review comments

@dsanders11 dsanders11 dsanders11 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @dsanders11 @ckerr @nikwen @VerteDinde