[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1 changes from 0-M131 #44649

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

ppontes
Copy link
Member
@ppontes ppontes commented Nov 13, 2024
electron/security#624 - 923797bac925 from chromium [M131] Make GetCacheIdentifier() respect GetSkipServiceWorker().

Since the current GetCacheIdentifier() ignores GetSkipServiceWorker(),
GetCacheIdentifier() returns ServiceWorkerId even if GetSkipServiceWorker()
is true if the ServiceWorker has a fetch handler.

To make the isolated world respected as an isolated world, the cache
identifier should not be shared with a page under a ServiceWorker control.

(cherry picked from commit 75f322ad1f64c0bc56fa77ab877b48d72cdb903c)

Bug: 372512079, 373263969
Change-Id: Idd2d8900f2f720e0a4dc9837e2eb56474c60b587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5961018
Reviewed-by: Justin Lulejian jlulejian@chromium.org
Reviewed-by: Kouhei Ueno kouhei@chromium.org
Commit-Queue: Yoshisato Yanagisawa yyanagisawa@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#1376006}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002191
Auto-Submit: Yoshisato Yanagisawa yyanagisawa@chromium.org
Commit-Queue: Kouhei Ueno kouhei@chromium.org
Cr-Commit-Position: refs/branch-heads/6778@{#1849}
Cr-Branched-From: b21671ca172dcfd1566d41a770b2808e7fa7cd88-refs/heads/main@{#1368529}

Notes:

@ppontes ppontes requested a review from a team as a code owner November 13, 2024 15:56
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 31-x-y labels Nov 13, 2024
@ppontes ppontes marked this pull request as draft November 13, 2024 16:43
@ppontes ppontes force-pushed the cherry-pick/security/31-x-y/0-m131 branch from 03c3f2e to bc50d09 Compare November 13, 2024 17:44
@ppontes ppontes marked this pull request as ready for review November 13, 2024 17:44
@ckerr ckerr merged commit 9c5c5d0 into 31-x-y Nov 13, 2024
49 checks passed
@ckerr ckerr deleted the cherry-pick/security/31-x-y/0-m131 branch November 13, 2024 23:25
Copy link
release-clerk bot commented Nov 13, 2024

Release Notes Persisted

  • Security: backported fix for CVE-2024-11110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
31-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants