Add validations to URL attribute on Link model #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Link < ActiveRecord::Base | ||
| validates :shortlink, presence: true, uniqueness: true | ||
| validates :url, presence: true | ||
| validates :url, presence: true, format: { with: URI::regexp(%w(http https)) } |
There was a problem hiding this comment.
Make sure this doesn't leave a vulnerability where you can do payloads like javascript:alert(1) http:// to circumvent this validation.
ebrynne
added a commit
that referenced
this pull request
Mar 20, 2015
Add validations to URL attribute on Link model
Closed
ebrynne
pushed a commit
that referenced
this pull request
Jan 26, 2018
Update Rails and fix security issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement to enforce only HTTP and HTTPS URLs can be entered. The list of allowed protocols can be easily extended if necessary in the Link model.