[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-batcher: use deterministic seed for test data #12129

Merged
merged 1 commit into from
Sep 25, 2024
Merged

op-batcher: use deterministic seed for test data #12129

merged 1 commit into from
Sep 25, 2024

Conversation

geoknee
Copy link
Contributor
@geoknee geoknee commented Sep 25, 2024 •
edited
Loading

The random test data was causing the TestChannelManager_TxData test to fail in approx 5% of cases.

With this change:

go run gotest.tools/gotestsum@latest ./... -run=TestChannelManager_TxData -count=1000 -v
∅  op-batcher/cmd
∅  op-batcher/metrics
∅  op-batcher/rpc
∅  op-batcher/compressor (816ms)
∅  op-batcher/flags (1.094s)
✓  op-batcher/batcher (59s)

DONE 5000 tests in 60.330s

@geoknee
use deterministic seed for test data
2526dc0 
This was causing the test to fail in approx 5% of cases
@geoknee geoknee requested review from a team as code owners September 25, 2024 20:20
@mslipper mslipper added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit d90e434 Sep 25, 2024
64 checks passed
@mslipper mslipper deleted the gk/batcher-test branch September 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslipper mslipper mslipper approved these changes

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/op-stack

@maurelian maurelian Awaiting requested review from maurelian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoknee @mslipper