UX: Cleanup mobile topic footer area #29204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bb334f
to
695cf44
Compare
fb1f41b
to
8c31667
Compare
chapoi
commented
Oct 22, 2024
| @id="topic_notification_levels" | ||
| @triggerSelector=".notifications-button" | ||
| @titleText={{i18n "user_tips.topic_notification_levels.title"}} | ||
| @contentText={{i18n "user_tips.topic_notification_levels.content"}} |
There was a problem hiding this comment.
Haven't been able to test this properly, if it's still works well
…/discourse/discourse into cleanup-mobile-topic-footer-area
f18c6af
to
9e50de7
Compare
|
Me trying to merge things broke stuff, so I reverted back to my last working version. I'll let someone more apt with merging handle it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any "uneven" spacing is caused by empty divs, courtesy of Ember. I'm opting to tolerate these for now, knowing they'll soon(ish) be gone, rather than doing only half a rework, and needing a revision later.
Desktop
With typing indicator
Check with all plugin outlets in use
Mobile
Narrow
Wide
With typing indicator
With ToC
Needs a little adjustment to ToC button, but will address that in ToC component
Check with all plugin outlets in use (not ideal obv)