[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): Exclude comment lines from coverage reports #25939

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(coverage): Exclude comment lines from coverage reports #25939

merged 1 commit into from
Oct 31, 2024

Conversation

usualoma
Copy link
Contributor

fixes #25938

I think comments should be excluded from line coverage.

current result

html-report-unpached

patched result

html-report-pached

@CLAassistant
Copy link
CLAassistant commented Sep 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@usualoma usualoma mentioned this pull request Sep 30, 2024
Closed
4 tasks
@bartlomieju
Copy link
Member

Thanks for the PR @usualoma, it looks good at first glance. We're a bit swamped with Deno 2.0 release ATM, so it might have a couple weeks before we merge it. Thanks!

@bartlomieju bartlomieju added this to the 2.1.0 milestone Oct 1, 2024
@bartlomieju
Copy link
Member

Note to self: compare how other tools like nyc or istanbul do that. Are the comment lines excluded from the total line count or are they always counted as covered.

@kt3k
Copy link
Member
kt3k commented Oct 28, 2024

Tested istanbul (via jest). The comment lines seem excluded from total line count.

Screenshot 2024-10-28 at 19 39 18

kt3k
kt3k approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member
@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 50ea707 into denoland:main Oct 31, 2024
17 checks passed
@usualoma usualoma deleted the fix-cli-coverage-comment-range-2 branch October 31, 2024 22:29
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@usualoma @bartlomieju
fix(coverage): exclude comment lines from coverage reports (#25939)
12c8b80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Exclude comment lines from coverage reports
4 participants
@usualoma @CLAassistant @bartlomieju @kt3k