[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor continent hack into custom places, and add 'world' and 'earth' #4699

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Refactor continent hack into custom places, and add 'world' and 'earth' #4699

merged 5 commits into from
Nov 1, 2024

Conversation

gmechali
Copy link
Contributor
@gmechali gmechali commented Nov 1, 2024

Adds World and Earth to the autocomplete.
Refactors the continent hack into a "Custom places" hack where we no longer rely on the place ID intermediary.

@gmechali gmechali requested a review from dwnoble November 1, 2024 16:06
@gmechali gmechali marked this pull request as ready for review November 1, 2024 16:11
dwnoble
dwnoble approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor
@dwnoble dwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanka Gabe!

@gmechali gmechali merged commit f9a2b0c into datacommonsorg:master Nov 1, 2024
9 checks passed
@gmechali gmechali deleted the earth branch November 1, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnoble dwnoble dwnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmechali @dwnoble