Accessibility Updates #4683
Merged
Accessibility Updates #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
approved these changes
Oct 22, 2024
| - `only("md")`: Returns true if the window is within the "md" screen size range (768px or larger and smaller than 1068px). | ||
| */ | ||
|
|
||
| interface BreakpointInterface<B extends Breakpoints = Breakpoints> { |
|
/gcbrun |
89f92c8
to
5aaa67f
Compare
…event invalid HTML, prevent accessibility issues with certain readers and prevent down-the-line JS issues if we rely on the ids).
… cannot yet be updated). In the long term, we could look at changing this so that it is no longer id based, but for now, there should only be one search box on the screen at the same time. So rather than simply hiding the desktop search box in mobile view, and vice versa, we are now selectively rendering the header in the containing React component. To facilitate this, this push also adds in a breakpoints hook that allows us to apply Bootstrap-like media queries on the TypeScript side (this hook may be more generally useful).
…he title being required (both are fine). If provided, alt will be used as the alt for the image; otherwise the title will be used.
…utton and the corresponding submenu. Adds aria-controls and aria-expanded to the button for better accessibility compliance
…hole header height
c669afd
to
cfe1148
Compare
…he header bar (no longer required now that we are selectively rendering the headers).
hqpho
added a commit
that referenced
this pull request
Nov 4, 2024
The height attribute has not been applied since #4683 changed `#main-header-logo` to `.main-header-logo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements improvements following an accessibility sweep of the home page, and includes the following fixes and improvements: