improved some logging in workflow activities #8278
Open
+103
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filinto Duran <filinto@diagrid.io>
JoshVanL
requested changes
Nov 13, 2024
Signed-off-by: Filinto Duran <filinto@diagrid.io>
ac6f141
to
36c5b28
Compare
Signed-off-by: Filinto Duran <filinto@diagrid.io>
JoshVanL
requested changes
Nov 14, 2024
charts/dapr/charts/dapr_sidecar_injector/templates/dapr_sidecar_injector_deployment.yaml
Outdated
Show resolved
Hide resolved
charts/dapr/charts/dapr_sidecar_injector/templates/dapr_sidecar_injector_deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Filinto Duran <filinto@diagrid.io>
|
@JoshVanL please take another look when you have time. thx |
JoshVanL
requested changes
Nov 14, 2024
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Filinto Duran <duranto@gmail.com> Signed-off-by: Filinto Duran <filinto@diagrid.io>
c6b6362
to
86df23d
Compare
cicoyle
approved these changes
Nov 19, 2024
elena-kolevska
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change a few Debug logs to Info logs in workflow activities to better understand workflows without a full debug logging.
Issue reference
Please reference the issue this PR will close: #8279
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: