Verify Scheduler Enabled #8238
Open
Verify Scheduler Enabled #8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
artursouza
approved these changes
Oct 24, 2024
JoshVanL
requested changes
Oct 25, 2024
| rt.jobsManager.Run, | ||
| ) | ||
| if err != nil { | ||
| log.Errorf("Scheduler enabled, but dapr failed to connect. Unable to use the Jobs API.") |
There was a problem hiding this comment.
This error must be returned.
| @@ -334,6 +332,16 @@ func newDaprRuntime(ctx context.Context, | |||
| }, | |||
| ) | |||
|
|
|||
| if runtimeConfig.SchedulerEnabled() { | |||
There was a problem hiding this comment.
Both of these runners are designed to be able to run, regardless of whether there are any addresses/clients. Scheduler is also signaled as enabled if there is a non zero number of addresses. It's not clear to me why we need this change at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify Scheduler is enabled before connecting.