-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests for metrics in the Placement Service and a few fixes #8218
Open
elena-kolevska
wants to merge
11
commits into
dapr:master
Choose a base branch
from
elena-kolevska:metrics-test-placement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Integration tests for metrics in the Placement Service and a few fixes #8218
elena-kolevska
wants to merge
11
commits into
dapr:master
from
elena-kolevska:metrics-test-placement
+641
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
changed the title
Adds integration tests for metrics in the placement service
Adds integration tests for metrics in the Placement Service
Oct 23, 2024
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
changed the title
Adds integration tests for metrics in the Placement Service
Integration tests for metrics in the Placement Service and a few fixes
Oct 23, 2024
JoshVanL
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan 😄
elena-kolevska
commented
Oct 24, 2024
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding integration tests before the Open Census to the Open Telemetry change, so we can confirm that no regressions have been introduced.
It also addresses #8175
Issue reference
#7225
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: