[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typescript definitions #284

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: typescript definitions #284

merged 1 commit into from
Jun 6, 2023

Conversation

markin-io
Copy link
@markin-io markin-io commented Jun 6, 2023 •
edited
Loading

Issue being fixed or feature implemented

Fixed issue with the type system export and addressed some typings bugs

What was done?

  • Fixed bugs in existing typings systems
  • Made types accessible in both *.ts and *.d.ts (Got rid of export declare module and exported types directly from the root index.d.ts)
  • Added basic tests for exported type definitions

How Has This Been Tested?

  • CI
  • Tested imports in wallet-lib's *.d.ts definitions
  • Tested imports in SDK TS code

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@markin-io markin-io changed the title test: add tests for typings and fix bugs fix: typescript definitions Jun 6, 2023
jawid-h
jawid-h approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator
@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me 👍

shumkov
shumkov approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member
@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io merged commit 8477d62 into master Jun 6, 2023
@Mhmonicox Mhmonicox mentioned this pull request May 25, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 30, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 28, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 24, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawid-h jawid-h jawid-h approved these changes

@shuplenkov shuplenkov shuplenkov approved these changes

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markin-io @shumkov @shuplenkov @jawid-h