[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging and bugfixing to conf #3167

Merged
merged 8 commits into from
Nov 20, 2024
Merged

added logging and bugfixing to conf #3167

merged 8 commits into from
Nov 20, 2024

Conversation

hagen-danswer
Copy link
Contributor
@hagen-danswer hagen-danswer commented Nov 20, 2024

Description

  • we now log all calls
  • links and page within pages are now captured separately
  • we deal with problematic retrievals
  • we now track all pages fetched recursively to prevent infinite loops
  • iterables now yield one at a time for cleaner code
  • confluence client is now a property

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link
vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:22pm

@hagen-danswer hagen-danswer added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit e89dcd7 Nov 20, 2024
12 checks passed
rkuo-danswer added a commit that referenced this pull request Nov 20, 2024
* standardized escaping of CQL strings

* think i found it

* fix

* should be fixed

* added handling for special linking behavior in confluence

* Update onyx_confluence.py

* Update onyx_confluence.py

---------

Co-authored-by: rkuo-danswer <rkuo@danswer.ai>
@hagen-danswer hagen-danswer deleted the confluence-logging branch November 20, 2024 19:06
hagen-danswer added a commit that referenced this pull request Nov 20, 2024
* standardized escaping of CQL strings

* think i found it

* fix

* should be fixed

* added handling for special linking behavior in confluence

* Update onyx_confluence.py

* Update onyx_confluence.py

---------

Co-authored-by: rkuo-danswer <rkuo@danswer.ai>
rkuo-danswer added a commit that referenced this pull request Nov 21, 2024
added logging and bugfixing to conf (#3167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants