[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epileptic bug on MacOS #23

Open
ronangaillard opened this issue Apr 20, 2021 · 9 comments
Open

Epileptic bug on MacOS #23

ronangaillard opened this issue Apr 20, 2021 · 9 comments

Comments

@ronangaillard
Copy link
ronangaillard commented Apr 20, 2021

I cloned your project and run make and I was left with this epileptic bug :

Apr-20-2021 12-23-23

Maybe this has something to do with high DPI screens ?

Commit I used : 532f88c

System info :

image

@equalsraf
Copy link

I was seeing a similar issue in Linux/X11 with an intel card.

I changed the hi-dpi value in settings.json to false, and was able to avoid the issue.

  "hiDPI": false,

@dyaskur
Copy link
dyaskur commented Apr 20, 2021

Screen Shot 1442-09-09 at 6 03 27 PANGERAN

my settings.json:

{
  "homepage":"thdwb://homepage/",
  "windowWidth": 1600,
  "windowHeight": 900,

  "hiDPI": false,

  "experimentalHTML": false,
  "experimentalLayout": false
}

@montyanderson
Copy link

Also got this issue on Mac OS.

"hiDPI": false makes the window a little larger but still a small portion of the total window size.

@raff
Copy link
raff commented Apr 22, 2021

At least on MacOS it seems that when using hiDPI the scale is reversed. I.e. in https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L35:

window := &Window{ title: title, width: int(float32(width) / xscale), height: int(float32(height) / yscale), hiDPI: hiDPI,
it should really be:

width: int(float32(width) * xscale), height: int(float32(height) * yscale),

That makes the window content fill the window (but then it goes back to small with flicker on resize, so I think the same needs to be done wherever the window resize code is).

@bigwhite
Copy link

I got this issue on Mac OS, too.

ajzaff added a commit to ajzaff/thdwb that referenced this issue Apr 27, 2021
@ajzaff
Copy link
Contributor
ajzaff commented Apr 27, 2021

@raff That seems plausible for the scale issue. The resize callback is here: https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L139
I pushed the fix to my branch if anyone cares to try it? https://github.com/ajzaff/thdwb/tree/feature-content-scale-23

FWIW hiDPI did not work well on my chromebook even with my fix.

@danfragoso
Copy link
Owner

Hi, sorry for the delay, I've been really busy with work this couple of weeks. I fixed the scaling issue on linux with commit 088ec74, can you guys try it again?

@ronangaillard @dyaskur @montyanderson @raff @bigwhite @ajzaff

@dyaskur
Copy link
dyaskur commented Apr 27, 2021

On my mac still has same result

Screen Shot 1442-09-16 at 2 29 18 PANGERAN

@raff
Copy link
raff commented Apr 27, 2021

@dyaskur, if you applied https://github.com/ajzaff/thdwb/tree/feature-content-scale-23, make sure you have hiDPI=true in settings.json.

The fix is still not perfect (on resizes there are cases depending on the window size where the screen goes white) but mostly works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants