-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes 1.26 upgrade #2458
Open
tfriedel
wants to merge
38
commits into
cortexlabs:master
Choose a base branch
from
PEAT-AI:k8s-1.26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kubernetes 1.26 upgrade #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heus operator / config reloader, fluentbit, cluster autoscaler, metrics server, neuron device plugin and scheduler
…ntry sdk and pyyaml
…ni-k8s@v1.12.6 with controller-runtime
…isabled checking for license comments
… default) and set container-runtime to containerd, as dockerd is not supported after kubernetes 1.24
…erd to containerd. While the cluster now starts, we can't use cortex deploy because it requires docker. Need to find a way to give it access to docker.
…rted with containerd instead of dockerd
Awesome work 😎 thanks for keeping the project alive! I'll test this out on our setup this week. |
…are created in the same account. We now create roles per cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cortex to Kubernetes 1.26 and also updates most components to newer versions as described in versions.md.
An attempt to upgrade to Kubernetes 1.27 was made, but it was unsuccessful because of an open issue of the amazon-vpc-cni-k8s plugin with the Prometheus adapter.
Notes:
go run build/generate_ami_mapping.go manager/manifests/ami.json public
, however our AWS account can not access all regions, so we had to comment out regions that were not supported. Again, if someone wants to submit patch for this, it would be appreciated.looppointer: internal error: package "math" without types was imported
which we couldn't resolveE0610 20:44:44.563268. We assume it's a false alarm as metric collection seems to work, but if anyone has any insight into this, please let us know.
We ran 'make lint' and 'make test' and did manual testing with our model server over 2 days and have not noticed any issues yet. We did not run the e2e tests in the Makefile.
For some reason the circleCI script doesn't find the linter, even though it's installed and the PATH modification also looks correct. If someone knows how to fix it, please let us know.
Please test this thoroughly yourself before using it in production.
To use this version you will have to build self-hosted images. Follow the steps in
CONTRIBUTING.md up till "make images-all" and also read self-hosted-images.
Use go1.20.4 linux/amd64. A user tried go 1.21 and it didn't work with this version.
edit: we are running this version in production for a week and have not noticed any problems. We only use the realtime API.
checklist:
make test
andmake lint
summary.md
(view in gitbook after merging)